Connection: added inTransaction()#218
Open
pavolbiely wants to merge 1 commit into
Open
Conversation
dg
force-pushed
the
master
branch
5 times, most recently
from
March 17, 2019 06:22
9b70c0e to
dfb79e3
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
April 1, 2019 04:56
cba566a to
302586e
Compare
Author
|
Is there something wrong with the implementation? I could help but got no response. |
Contributor
|
@dg What do you think? |
Member
|
Please can you add simple test? |
dg
force-pushed
the
master
branch
2 times, most recently
from
November 19, 2019 18:28
4c0e8d0 to
e17242a
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
December 13, 2019 18:06
f9fc19d to
dd75e74
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 27, 2019 03:53
cce6a9c to
7e705c5
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
March 27, 2020 11:52
9acf825 to
a268c60
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
June 9, 2020 14:19
a56e7fe to
d9b5f29
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
March 4, 2021 19:57
82f287a to
fbffc75
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
April 5, 2021 15:44
07bedd3 to
d87063e
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
April 23, 2021 18:59
e29b33b to
ba62a2a
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 4, 2021 18:48
5e1c47e to
9f3937f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
inTransaction()method might be a very useful shortcut.Calling is unnecessary long right now.
Why not just use it like this?
Other shortcuts like
beginTransaction(),commit()androllback()are already implemented inConnectionclass.